Skip to content

Use html_url in push events#43

Merged
vermakhushboo merged 2 commits intomainfrom
fix-use-html_url-instead-of-url
Jun 2, 2025
Merged

Use html_url in push events#43
vermakhushboo merged 2 commits intomainfrom
fix-use-html_url-instead-of-url

Conversation

@vermakhushboo
Copy link
Copy Markdown
Contributor

@vermakhushboo vermakhushboo commented Jun 2, 2025 •
edited by coderabbitai bot
Loading

url starts with api.github.com whereas html_url starts with github.com..

Summary by CodeRabbit

  • Bug Fixes
    • Updated repository and branch URLs in push event notifications to use the correct web URLs for improved accuracy and user experience.

@vermakhushboo vermakhushboo requested a review from Meldiron June 2, 2025 09:10
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 2, 2025 •
edited
Loading

Walkthrough

The getEvent method in the GitHub adapter was updated so that, during 'push' events, the URLs for the branch and repository are now derived from the html_url field in the payload instead of the url field. No other logic or data structures were altered.

Changes

File(s) Change Summary
src/VCS/Adapter/Git/GitHub.php Modified 'push' event in getEvent to use html_url for branch and repository URLs.
tests/VCS/Adapter/GitHubTest.php Updated test payload in testgetEvent to replace repository "url" field with "html_url".

Possibly related PRs

  • Check value of deleted on push #42: Both PRs modify the getEvent method in GitHub.php to enhance the handling of push events by changing how event data is extracted and returned, indicating a direct relation in their code-level changes.

Suggested reviewers

  • Meldiron

Poem

A hop and a skip through the GitHub domain,
URLs now sparkle, no longer plain.
From url to html_url we leap,
Making our links pretty and neat.
Rabbits rejoice in this tidy new view—
Code made clearer, for me and for you!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4835ea9 and 2d5a4f4.

📒 Files selected for processing (1)
  • tests/VCS/Adapter/GitHubTest.php (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • tests/VCS/Adapter/GitHubTest.php
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 2, 2025
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a51ca92 and 4835ea9.

📒 Files selected for processing (1)
  • src/VCS/Adapter/Git/GitHub.php (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests
src/VCS/Adapter/Git/GitHub.php

[error] 594-594: PHPUnit test error: Undefined array key "html_url" in GitHub.php at line 594.

@vermakhushboo vermakhushboo merged commit f635b36 into main Jun 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Meldiron Meldiron Meldiron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vermakhushboo @Meldiron